Test api.c: change more tests to use Expect instead of Assert#6530
Merged
dgarske merged 1 commit intowolfSSL:masterfrom Jun 26, 2023
Merged
Test api.c: change more tests to use Expect instead of Assert#6530dgarske merged 1 commit intowolfSSL:masterfrom
dgarske merged 1 commit intowolfSSL:masterfrom
Conversation
SparkiDev
force-pushed
the
tests_api_expect_5
branch
6 times, most recently
from
a1fb893 to
2d8dbf1
Compare
dgarske
requested changes
Jun 23, 2023
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
tests/api.c:58157:39: error: ‘WOLFSSL_SESSION’ has no member named ‘ticket’
58157 | if (bad && (sess != NULL) && (sess->ticket != NULL)) {
| ^~
make[2]: *** [Makefile:7079: tests/unit_test-api.o] Error 1```
SparkiDev
force-pushed
the
tests_api_expect_5
branch
from
2d8dbf1 to
d4b4260
Compare
Contributor
Author
|
Fixed check of sess->ticket to be in #ifdef |
SparkiDev
force-pushed
the
tests_api_expect_5
branch
from
d4b4260 to
188933f
Compare
dgarske
requested changes
Jun 26, 2023
Member
dgarske
left a comment
dgarske
left a comment
There was a problem hiding this comment.
tests/api.c:22621:5: error: ISO C90 forbids mixed declarations and code [-Werror=declaration-after-statement]
22621 | WC_RNG rng;
| ^~~~~~
cc1: all warnings being treated as errors
make[2]: *** [Makefile:7075: tests/unit_test-api.o] Error 1
bio.c: wolfSSL_BIO_flush(): check allocation to bio->ip succeeded. internal.c: InitSSL_Ctx(): set ctx->heap to heap if value passed in ProcessPeerCerts(): check for error MEMORY_E too as a fatal parsing error ssl.c: wolfSSL_shutdown(): SOCKET_ERROR_E is also an indication that the socket is done, MEMORY_E is a fatal error wolfSSL_Cleanup(): move free of memory fail couting to wolfSSL API SessionTicketNoncePrealloc(): eror return must be non-zero AddSessionToCache(): XFREE checks for NULL no need to do it before call wolfSSL_set_psk_use_session_callback(): ensure ssl is not NULL before dereferencing wolfSSL_SMIME_read_PKCS7(): check for error return from wolfSSL_BIO_gets() asn.c: wc_MIME_parse_headers(): check allocation succeeded into nextHdr compress.c: wc_DeCompressDynamic(): free tmp on inflateInit2 failure memory.c: rework where memory allocation failure counting code for when WOFLSSL_STATIC_MEMORY is defined wc_port.c: wolfCrypt_Cleanup(): only call wc_MemFailCount_Free() when no wolfSSL_Cleanup()
SparkiDev
force-pushed
the
tests_api_expect_5
branch
from
188933f to
578f56e
Compare
Contributor
Author
|
fixed |
dgarske
approved these changes
Jun 26, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
wc_port.c:
wolfCrypt_Cleanup(): only call wc_MemFailCount_Free() when no
wolfSSL_Cleanup()
Testing
Memory allocation failure testing as well.
Checklist